Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retire non-supported Go versions #493

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Aug 2, 2022

  • chore: retire not supported Go versions from CI
  • chore: better CI step name

What does this PR do?

It retires Go 1.14 and 1.15 from the CI, in both testing pipelines (Docker and Podman)

Why is it important?

New PRs using code from 1.16 and above will fail because of the CI complains that the code does not compile in older Go versions

This specially important for security fixes provided by dependabot

Related issues

@mdelapenya mdelapenya added dependencies Dependencies or external services chore Changes that do not impact the existing functionality labels Aug 2, 2022
@mdelapenya mdelapenya self-assigned this Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #493 (bbd4c26) into main (1ebb44c) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   70.06%   69.77%   -0.30%     
==========================================
  Files          21       21              
  Lines        2048     2048              
==========================================
- Hits         1435     1429       -6     
- Misses        491      495       +4     
- Partials      122      124       +2     
Impacted Files Coverage Δ
docker.go 71.33% <0.00%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@mdelapenya
Copy link
Member Author

Merging, as Go 1.14 and Go 1.15 are not supported anymore. See https://go.dev/doc/devel/release#policy

Each major Go release is supported until there are two newer major releases. For example, Go 1.5 was supported until the Go 1.7 release, and Go 1.6 was supported until the Go 1.8 release. We fix critical problems, including critical security problems, in supported releases as needed by issuing minor revisions (for example, Go 1.6.1, Go 1.6.2, and so on).

@mdelapenya mdelapenya merged commit 0581b2f into testcontainers:main Aug 2, 2022
@mdelapenya mdelapenya deleted the retire-old-go-versions branch October 3, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retire Go 1.14 and 1.15 from CI checks
1 participant