Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Docker Compose V2 #377

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Add support for Docker Compose V2 #377

merged 1 commit into from
Feb 16, 2022

Conversation

artamonovkirill
Copy link
Contributor

@artamonovkirill artamonovkirill commented Nov 8, 2021

Related issues

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #377 (e1be58a) into master (95e84a0) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   64.93%   65.22%   +0.29%     
==========================================
  Files          19       19              
  Lines        1155     1159       +4     
==========================================
+ Hits          750      756       +6     
+ Misses        301      299       -2     
  Partials      104      104              
Impacted Files Coverage Δ
compose.go 76.02% <100.00%> (+0.67%) ⬆️
docker.go 65.58% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e84a0...e1be58a. Read the comment docs.

@artamonovkirill artamonovkirill changed the title Add support for MacOS generated and compose-file container names Add support for Docker Compose V2 Nov 18, 2021
@portey
Copy link

portey commented Dec 1, 2021

Hi guys,
Thanks for your effort!

Do you have plans to merge this pr in order to unblock all users who use docker-compose V2?

compose.go Outdated Show resolved Hide resolved
@mdelapenya
Copy link
Member

As discussed in #404, I think this change is required to support multiple versions of docker-compose.

Thanks for your help during the review

@mdelapenya mdelapenya merged commit c0c2f90 into testcontainers:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants