Bugfix: log-consumer go-routine should recover from closed-connection #369
+102
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 62.66% 62.66%
=======================================
Files 15 15
Lines 1015 1015
=======================================
Hits 636 636
Misses 280 280
Partials 99 99
Continue to review full report at Codecov.
|
mdelapenya
reviewed
Dec 3, 2021
| nginx.FollowOutput(&consumer) | ||
|
|
||
| // Gather the initial container logs | ||
| time.Sleep(time.Second * 1) |
There was a problem hiding this comment.
Do you foresee medium-term, potential issues with the sleep time not being enough?
mdelapenya
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Thanks for this contribution @Chrisss93 ! I do not see anything weird with it, so LGTM
About bc6fdab, it was not a direct commit to master but a PR: #323 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As best I can tell, a direct commit to the master branch bc6fdab made an attempt at recovering the log-position of a container in the scenario of a closed connection. The logic is all sound, but I think the string used to detect a closed-connection is not (has never been) correct.
The source of the error is
internal/poll'serrNetClosing. It's error string has been set as:"use of closed network connection"since the beginning (5 years ago). Of course it would be much cleaner to detect a connection-closed error without string-matching but as stated in the mentioned commit, the error type for this was only exported by thenetpackage in go 1.16