-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container examples to documentation, clean up README #353
Conversation
CC @mdelapenya since we last talked about docs in one of the linked issues. No rush here necessarily though. |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 61.91% 61.91%
=======================================
Files 15 15
Lines 1011 1011
=======================================
Hits 626 626
Misses 288 288
Partials 97 97 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jaredpetersen this LGTM, although there are conflicts in the modules section (a PR was merged with kafka canned container). Could you please resolve them? I will approve these changes right after, as I see them as a great improvement for the project. Great job with the clean-up!!
Co-authored-by: Manuel de la Peña <social.mdelapenya@gmail.com>
I'll get on that conflict ASAP. Thanks for reviewing 👍 |
Fixed those conflicts, ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay 🙏 AND this LGTM 👍
This is a multipart documentation update.
I added code samples for how to use Testcontainers-Go with CockroachDB, Redis, and NGINX per the discussion in #112 and #351. I've run all of the example code to make sure that everything completes as expected.
I know there are more examples from past closed PRs for things like Minio, MongoDB, and Postgres that the old canned modules documentation referenced. However, since canned modules are now a dead concept, sharing that code won't be very helpful and it needs some tweaking in order to fit into this new example-based documentation model. I'd like to contribute Postgres, MySQL, and Kafka + Schema Registry examples too but I'll need more time for those. This is a good starting point though and we can begin helping people now rather than later.
I also updated the README a bit so that it uses language from more of a project perspective rather than an individual author perspective per #351. I also found that the existing NGINX example no longer compiles because it referenced a no longer existing
Terminate(ctx context.Context, t *testing.T)
function.The project description on GitHub has a grammatical issue that should be fixed. The word "provides" should be used instead of "providing":
However, I would instead suggest replacing the project description entirely with the following:
It just needs to be small, quick hook rather than a two sentence summary 🙂