Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable var-declaration from revive linter #2942

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mmorel-35
Copy link
Contributor

What does this PR do?

revive is a linter for Go. Drop-in replacement of golint.

This PR list default rules and focus on applying var-declaration rule at first

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4b5543f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67973eb03e415a0008bfff96
😎 Deploy Preview https://deploy-preview-2942--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmorel-35 mmorel-35 changed the title golangci-lint: enable revive linter chore: enable revive linter Jan 15, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive branch 2 times, most recently from b6ff205 to 479822f Compare January 15, 2025 06:54
@mmorel-35 mmorel-35 changed the title chore: enable revive linter chore: enable var-declaration from revive linter Jan 15, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint/revive branch from 479822f to 37040ac Compare January 15, 2025 06:59
@mmorel-35 mmorel-35 marked this pull request as ready for review January 15, 2025 07:43
@mmorel-35 mmorel-35 requested a review from a team as a code owner January 15, 2025 07:43
mdelapenya
mdelapenya previously approved these changes Jan 15, 2025
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this improvement 👏

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jan 15, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit 28fa547 into testcontainers:main Jan 27, 2025
124 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/revive branch January 27, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants