Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log test data race #2863

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: log test data race #2863

merged 1 commit into from
Oct 30, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Oct 30, 2024 •
edited by mdelapenya
Loading

Fix a data race when accessing logger in consumer test.

Closes #2862

@stevenh
fix: log test data race
96f5e53 
Fix a data race when accessing logger in consumer test.
@stevenh stevenh requested a review from a team as a code owner October 30, 2024 16:08
@netlify Netlify
Copy link

netlify bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 96f5e53
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67225a0b53665e000866f60d
😎 Deploy Preview https://deploy-preview-2863--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh requested a review from mdelapenya October 30, 2024 16:14
mdelapenya
mdelapenya approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya merged commit a489482 into main Oct 30, 2024
122 checks passed
@mdelapenya mdelapenya self-assigned this Oct 30, 2024
@mdelapenya mdelapenya deleted the fix/log-data-race branch October 30, 2024 16:54
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: race condition on reaper and logs
2 participants
@stevenh @mdelapenya