fix: use Contains or ErrorContains with testify
#2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @stevenh |
fb53979 to
3fe1467
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
3fe1467 to
7bc8a60
Compare
stevenh
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It uses
require.Contains(t,...)orrequire.ErrorContains(t, err,...)when possibleIt also removes
require.Error(t, err,...)as it is redundant withrequire.ErrorContains(t, err,...)behaviorWhy is it important?
To simplify code and not omit to check that error happened befort checking it's message content.
Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com