Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow viewing of logs from stopped container #120

Conversation

ClaytonNorthey92
Copy link
Contributor

@ClaytonNorthey92 ClaytonNorthey92 commented Dec 3, 2019

setting any container besides a reaper to not auto-remove when creating

fixes #118

Now when creating containers, allowing a user to set the AutoRemove parameter in the container request, if this is done, then the container will be removed upon stopping. This is by default set to false for user-created containers, but when running a reaper container, this will set it to true (reaper cleans up containers, but nothing cleans up reaper so we have to make sure it auto-removes)

@ClaytonNorthey92
Copy link
Contributor Author

I am contemplating adding this to the README or not...the only time a user would ever want to change this is if they are skipping the reaper container, I know we provide that option, but does that happen often?

@ClaytonNorthey92 ClaytonNorthey92 force-pushed the feature/logs-of-failed-container branch 2 times, most recently from a6520b6 to d42fc81 Compare December 4, 2019 00:02
fixes testcontainers#118

setting any container besides a reaper to not auto-remove when creating
@ClaytonNorthey92 ClaytonNorthey92 force-pushed the feature/logs-of-failed-container branch from d42fc81 to f79a5b2 Compare December 25, 2019 14:20
@gianarb
Copy link
Member

gianarb commented Jan 8, 2020

I think we can leave it out for now. At some point, we will have to figure out how to set up a proper doc I presume!

@gianarb gianarb merged commit f8e3cda into testcontainers:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow Ability to View Logs from Failed-to-Start Container
2 participants