-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kafka (KRaft Mode) module #1034
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @noctarius this is awesome! I have one question regarding how you created the scaffolding, as I'm not sure if you used the module generator tool, as described here? It will generate the scaffolding and will automatically add it to the docs site (golang.testcontainers.org). |
I just copy and pasted what I found for other modules, so no, I didn't use the tool 🤷♂️ |
Kudos, SonarCloud Quality Gate passed! |
Hey @noctarius sorry for the radio silence, but we have been working on a more consistent module design, so I'd ask you to visit the docs on how to adhere to this design here: https://golang.testcontainers.org/modules/ In two sentences, the entrypoint must be I'd be very happy to review your PR following this new design 🙏 |
@noctarius Just recently we released an official Redpanda module, maybe that helps you for integration tests. It starts faster than any Kafka container (generally more lightweight), it's Kafka API compatible and also comes with schema registry support. |
@noctarius did you take a look at #1034 (comment)? In any case, please let me know if you want to keep this Kafka module, I could dedicate time with you to update the PR to use the new design for modules |
Just a comment from the sidelines, I think it's worthwhile to keep this. If you're testing an application that should be compatible with Apache Kafka and Redpanda, I think it does make sense to test with them both. |
@srenatus cool then. Is anybody willing to contribute it? I'd start a new PR, or rewrite this one, using the new APIs for modules, just copying the functionality in this PR. |
Hey folks! Sorry for the long abstinence. Happy to make a new version of this but not sure when I get to that. If anyone wants to chime in, feel free :) |
I have a working PR for this. Will submit and close this one. Thanks for the initial work here @noctarius!! I will add you to #636 as contributor of the kafka module |
What does this PR do?
This PR adds a new module for Kafka, running in KRaft (Zookeeper-less) mode
Why is it important?
New modules are always important :-)
Related issues
How to test this PR
Simple test for the module is included