Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the wait/multi.go file to wait/all.go: #537

Closed
mdelapenya opened this issue Sep 28, 2022 · 1 comment · Fixed by #541
Closed

Rename the wait/multi.go file to wait/all.go: #537

mdelapenya opened this issue Sep 28, 2022 · 1 comment · Fixed by #541
Labels
chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest.

Comments

@mdelapenya
Copy link
Member 

    As discussed, we are going to rename the `multi.go` file to `all.go`:
  • consistency with Java
  • the exposed API is not changed (wait.ForAll)

Originally posted by @mdelapenya in #536 (comment)
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest. labels Sep 28, 2022
@skofli
Copy link
Contributor

skofli commented Sep 30, 2022

Hey! I would like to work on this issue

skofli added a commit to skofli/testcontainers-go that referenced this issue Oct 1, 2022
@skofli
issue testcontainers#537 Rename the wait/multi.go file to wait/all.go
dd81fd3
@mdelapenya mdelapenya mentioned this issue Oct 1, 2022
Merged
mdelapenya pushed a commit that referenced this issue Oct 1, 2022
@skofli
issue #537 Rename the wait/multi.go file to wait/all.go (#541)
bdb1026
mdelapenya referenced this issue in mdelapenya/testcontainers-go Dec 21, 2022
@mdelapenya
Merge branch 'main' into bump-transitive-deps-security-concerns
e71db4a 
* main:
  Add system requirements parent docs page for podman and colima (#562)
  Support for cap-add/cap-drop (#555)
  fix container NetworkMode usage (#560)
  chore: use hashed versions of test-summary action (#556)
  chore: use container.State() function in tests (#543)
  Log docker server info (#548)
  docs: add docs regarding Colima usage (#547)
  chore: add emoji to breaking changes in release drafter (#542)
  chore: add CONTRIBUTING file (#539)
  issue #537 Rename the wait/multi.go file to wait/all.go (#541)
  docs: add a basic layout for wait strategies in docs (#536)
  docs: improve consistency and fix typos (#534)
  chore: do not skip test (#528)
  chore: include test flakiness in the release drafter (#535)
  chore: retire old versions of Go (#530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Changes that do not impact the existing functionality hacktoberfest Pull Requests accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue #537 Rename the wait/multi.go file to wait/all.go skofli/testcontainers-go
2 participants
@mdelapenya @skofli