Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Redpanda): Add missing command-line arguments to the startup script (smp, memory) #1364

Conversation

RobotechUSA
Copy link
Contributor

What does this PR do?

Fixes issues when multiple concurrent redpanda test containers are running and some fail to startup due to resouce exhaustion

Updated Startup Script to include command line arguments for smp and memory
Command Line argument Values are now consitent with python, go, java, node and ruby implementations:

Why is it important?

These updated values adresses the scenario where multiple redpanda test containers instances are wired up and that some containers stop / fail due to resource exhaustion. The following error is captured from the container which has failed:

2025-02-07 09:45:20 WARN  2025-02-07 17:45:20,613 seastar - Requested AIO slots too large, please increase request capacity in /proc/sys/fs/aio-max-nr. available:6559 requested:110260 
2025-02-07 09:45:20 Could not initialize seastar: std::runtime_error (Could not setup Async I/O: Not enough request capacity in /proc/sys/fs/aio-max-nr. Try increasing that number or reducing the amount of logical CPUs available for your application)

Related issues

N/A -> No open issues have been reported

…memory

Command Line argument Values are now consitent with python, go, java, node and ruby implementations:
- https://github.com/testcontainers/testcontainers-python/blob/main/modules/kafka/testcontainers/kafka/_redpanda.py
- https://github.com/testcontainers/testcontainers-go/blob/main/modules/redpanda/redpanda.go
- https://github.com/testcontainers/testcontainers-java/blob/main/modules/redpanda/src/main/java/org/testcontainers/redpanda/RedpandaContainer.java
- https://github.com/testcontainers/testcontainers-node/blob/main/packages/modules/redpanda/src/redpanda-container.ts
- https://github.com/testcontainers/testcontainers-ruby/blob/main/redpanda/lib/testcontainers/redpanda.rb

These updated values adresses the scenario where multiple redpanda test containers instances are wired up and that some containers stop / fail due to resource exhaustion. The following error is captured from the container which has failed:

2025-02-07 09:45:20 WARN  2025-02-07 17:45:20,613 seastar - Requested AIO slots too large, please increase request capacity in /proc/sys/fs/aio-max-nr. available:6559 requested:110260
2025-02-07 09:45:20 Could not initialize seastar: std::runtime_error (Could not setup Async I/O: Not enough request capacity in /proc/sys/fs/aio-max-nr. Try increasing that number or reducing the amount of logical CPUs available for your application)
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 17d4ec5
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67a64f03a036b500087b9c28
😎 Deploy Preview https://deploy-preview-1364--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobotechUSA RobotechUSA marked this pull request as ready for review February 7, 2025 18:43
@HofmeisterAn HofmeisterAn added bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups labels Feb 9, 2025
@HofmeisterAn HofmeisterAn changed the title Fix: Redpanda Test Container - Added missing command line arguments for startup script to be consistent with other language implementations fix(Redpanda): Add missing command-line arguments to the startup script (smp, memory) Feb 9, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for referencing the configuration and implementation in other languages.

@HofmeisterAn HofmeisterAn merged commit ce1d5e1 into testcontainers:develop Feb 9, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants