Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove binding of ports to IPv4 only #1363

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

daviian
Copy link
Contributor

@daviian daviian commented Feb 7, 2025

What does this PR do?

Removes the HostIP from the Port Binding so that it does not restrict itself to IPv4.

Why is it important?

Not needed anymore.

Related issues

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a58e52e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67a5ee8de69aa50008379350
😎 Deploy Preview https://deploy-preview-1363--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups labels Feb 7, 2025
@HofmeisterAn HofmeisterAn changed the title chore: remove IPv4 Host IP from Port Binding chore: Remove binding of ports to IPv4 only Feb 7, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HofmeisterAn HofmeisterAn merged commit 231e814 into testcontainers:develop Feb 7, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ryuk container are not shutdown [Enhancement]: Resolve port bindings according to IPv4 and IPv6
2 participants