chore: Apply fix for github.com/apache/pulsar/issues/22811 only for affected versions #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c37d6a9 to
f46627b
Compare
|
I have made the changes and if it all looks good to you. Then it is ready to merge 😄 |
HofmeisterAn
requested changes
Aug 29, 2024
Sure i'll try 👍 |
0af766f to
bc4e60f
Compare
|
I have removed the unnecessary white spaces. |
bc4e60f to
3e6ff58
Compare
The default Pulsar image version changed from "3.2.3" to "3.0.6" due to a known regression impacting versions "3.2.0-3.2.3" and "3.3.0". The regression resulted in the expiry time being converted to an incorrect unit of time. The revision improves the check for affected versions by introducing the 'IsVersionAffectedByRegression' method, which accepts a version and returns true if the version is impacted by the regression. The formatting of the PulsarContainer.cs and PulsarBuilder.cs files was also updated for better readability. In addition, the `docs/modules/index.md` file was updated to reflect the new Pulsar version, making it easier for users to use the correct version.
3e6ff58 to
39f6e42
Compare
HofmeisterAn
reviewed
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit changes the default Pulsar image from version 3.2.3 to 3.0.6. Additionally, it updates the logic to specifically handle image version v3.2.0-3 and 3.3.0 due to known issues in certain versions. As it is fixed in 3.2.4 and 3.3.1. Please see https://pulsar.apache.org/release-notes/
Why is it important?
Right now the fix is applied to the latest tag. Which can cause issues. If the user decides to use the latest tag or use an Apache Pulsar version with the issue resolved.
How to test this PR
Ran all the tests