Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using NodeJS v16 as a action runtime #17

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Oct 11, 2022

NodeJS v12 is EOL and it's been deprecated since April 2022. It will stop being available in GitHub Actions CI/CD workflows by the summer
2023. But it already triggers deprecation warnings that show up on the workflow summary page:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

This patch fixes that.

Resolves #15

NodeJS v12 is EOL and it's been deprecated since April 2022. It will
stop being available in GitHub Actions CI/CD workflows by the summer
2023. But it already triggers deprecation warnings that show up on the
workflow summary page:
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

This patch fixes that.

Resolves test-summary#15
@webknjaz webknjaz force-pushed the maintenance/nodejs-16 branch from d0f5a07 to 307b9a8 Compare October 11, 2022 15:49
@webknjaz
Copy link
Contributor Author

Hey @ethomson, this one seems to be important enough to be merged ASAP.

@ethomson
Copy link
Member

Thanks for this!

@webknjaz
Copy link
Contributor Author

@ethomson could you cut a new release, please?

@ethomson
Copy link
Member

Indeed I will - I was changing some infrastructure bits around for the svg service this afternoon (faster! cheaper!) and will cut a release tonight or tomorrow morning once I'm sure those are all settled. 🙏

@webknjaz
Copy link
Contributor Author

Cool, thanks!

webknjaz added a commit to ansible-community/ansible-test-gh-action that referenced this pull request Oct 20, 2022
This resolves #41, since the said release addresses the deprecation
warning via test-summary/action#17.

Ref: test-summary/action#15

Closes #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS 12 deprecation warning pollutes workflow annotations when this action is used
2 participants