Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.3: Cannot read properties of undefined (reading 'message') #44

Closed
rschmidt-webit opened this issue Feb 26, 2024 · 8 comments · Fixed by #49
Closed

Release 2.3: Cannot read properties of undefined (reading 'message') #44

rschmidt-webit opened this issue Feb 26, 2024 · 8 comments · Fixed by #49

Comments

@rschmidt-webit
Copy link

Hey,

Using the new Release creates a error message, when the tests fails:
Cannot read properties of undefined (reading 'message')

Using 2.2 works as expected.

Bye :)

@andreyfel
Copy link

andreyfel commented Feb 27, 2024

Getting the same issue. Seems to be caused by this change: #40
@gstokkink would you be able to take a look?

@thomaschaplin
Copy link

Is there any update to this, please?

@gstokkink I wonder if your PR (#40) requires a specific requirements in the xml files - which not all will have.

cc @ethomson as they approved the PR (#40).

djbrown added a commit to djbrown/gnucash-android that referenced this issue Apr 18, 2024
@austinpray-mixpanel
Copy link

Seeing this as well. Sample Junit file is generated by https://storybook.js.org/ with the --junit option
junit_fail_scrubbed.xml

@ethomson
Copy link
Member

Thanks for adding a repro case @austinpray-mixpanel - I'll take a look. I think this should be unrelated to #40 ? But I'm not sure yet, I'll dig in.

@JanMa
Copy link

JanMa commented Jun 25, 2024

Hello @ethomson is there any update on this issue? I've just updated my project from version 2.1 to 2.3 and started to get the same error

JanMa added a commit to openbao/openbao that referenced this issue Jun 25, 2024
We're running into this open Issue which seems to have been introduced
in version 2.3:
test-summary/action#44

Signed-off-by: Jan Martens <jan@martens.eu.org>
JanMa added a commit to openbao/openbao that referenced this issue Jun 26, 2024
We're running into this open Issue which seems to have been introduced
in version 2.3:
test-summary/action#44

Signed-off-by: Jan Martens <jan@martens.eu.org>
@ethomson
Copy link
Member

@JanMa - apologies, looking now. 👀

Unrelated - I notice that you're pinning your actions to SHAs. (Which is a good practice.) Curious if you're doing this manually or using a tool to help?

@JanMa
Copy link

JanMa commented Jun 26, 2024

Thanks for the quick fix @ethomson, I really appreciate it 🙂
We're using Dependabot to get updates for our GitHub Actions and it uses the SHA to pin them

@ethomson
Copy link
Member

@JanMa Good to know. I just published v2.4, let me know if this doesn't resolve the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants