[CommandExecutor] Move ObjectSpace finalizer logic into executor. #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any remote shell cleanup needs to be handled by the CommandExecutor so that it attempts to close the last opened shell. Previous to this commit, the shell cleanup was in `Kitchen::Transport::Winrm` but only knew about the **initially** opened shell. The `ShellCloser` class was extracted to full class status as the user of `CommandExecutor` now has to supply a closer in the constructor if ObjectSpace cleanup behavior is desired (the default is to do no cleanup). Closes #656
|
So much better!
|
fnichol
added a commit
that referenced
this pull request
Mar 28, 2015
[CommandExecutor] Move ObjectSpace finalizer logic into executor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any remote shell cleanup needs to be handled by the CommandExecutor so
that it attempts to close the last opened shell. Previous to this
commit, the shell cleanup was in
Kitchen::Transport::Winrmbut onlyknew about the initially opened shell.
The
ShellCloserclass was extracted to full class status as the userof
CommandExecutornow has to supply a closer in the constructor ifObjectSpace cleanup behavior is desired (the default is to do no
cleanup).
Closes #656