[WIP] Puppet apply provisioner

[ChrisLundquist]

After looking at #83 and #197

I wanted to take a stab at a lower impact / more contained provisioner. After writing a shell provisioner it seemed like it could be done.

Currently this only sets up puppet 2.7 on ubuntu. It seems like moving to an omnibus installer would fix that up.

This works with hiera, but expects a hiera.yaml file somewhere in the directory tree. I wasn't sure if moving that to a template would be better.

The provisioner stanza in my .kitchen.yml looks like this

provisioner:
  name: puppet_apply
  manifests_path: /absolute/path/to/puppet/manifests
  modules_path: /absolute/path/to/puppet/modules
  hiera_data_path: /absolute/path/to/puppet/puppet/hieradata

manifests_path and modules_path first look in the currently directory tree, but I'm testing this on another code base so it is a little wonky. Note, you can't seem to use ~/path/puppet. If you do, nothing gets copied.

/cc @fnichol @jfryman
Do either of you know a good way to omnibus install puppet to fix this up?
What are your thought?
Are there use cases that I have overlooked?
What can we cleanup to make it more idiomatic?

[ericsakowski]

@ChrisLundquist I cloned this, swapped in a shell script I use to install PE 3.1.1 as opposed to the calls to apt, and was able to get it working. Two issues:

1. To make it to work on CentOS I had to remove the sudo for 'puppet apply' (sudo -E doesn't work on Cent).
2. Because of Net::SCP and OpenSSH scp -r not liking to scp into target directories that don't exist, I had to add a mkdir:
   def init_command
   "mkdir -p #{config[:root_path]}"
   end
   (which I stole from chef_base.rb)

...Not having that mkdir resulted in my modules getting copied into /tmp/kitchen/ntp, /tmp/kitchen/stdlib on the first run. On the second run, (kitchen converge default-centos-6-64 would fail the first run and work the second run) they would get to /tmp/kitchen/modules/ntp. It seemed net::scp was creating one dir in the path. I looked into patching net::scp or openssh but essentially gave up when I saw the OpenSSH team's FAQ saying they will not add anything to scp.

Anyway thanks for the PR and I hope this gets some traction!

[ChrisLundquist]

@ericsakowski can you gist the shell script you used to bootstrap it on centos? I was thinking if we cover ubuntu and centos bootstrapping we're doing alright.

Adding that mkdir command seems safe enough.

P.S. I'm really happy to hear that this helped you!

[ericsakowski]

Since the script is for enterprise I should probably make sure I'm not
violating any licenses. I'll look into that. It won't do free puppet but
that's got some repos so shouldn't be too hard to script....if I get some
free time I can look into that as well.

On Wed, Jan 8, 2014 at 6:39 PM, Chris Lundquist notifications@github.comwrote:

@ericsakowski https://github.com/ericsakowski can you gist the shell
script you used to bootstrap it on centos? I was thinking if we cover
ubuntu and centos bootstrapping we're doing alright.

Adding that mkdir command seems safe enough.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/291#issuecomment-31888536
.

Eric Sakowski

[ericsakowski]

@ChrisLundquist OK here you go: https://gist.github.com/ericsakowski/8338474

[cheeseplus]

Is this needed anymore with https://github.com/neillturner/kitchen-puppet ?

[ChrisLundquist]

two years is a long time.

[cheeseplus]

Totally, we've got some new maintainers so we're trying to clean house as part of the process. Apologies that it took so long for us to get back to you.

[ChrisLundquist]

❤️ I might have done some of what I needed in neillturner/kitchen-puppet#1
Looks like it has become more popular since then.