Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation/positional arguments #236

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Deprecation/positional arguments #236

merged 3 commits into from
Apr 1, 2022

Conversation

damacus
Copy link
Contributor

@damacus damacus commented Mar 31, 2022

Description

  • Fixes the ERB positional arguments
  • Runs unit tests after linters have run

Check List

  • New functionality includes tests
  • All tests pass
  • PR title is a worthy inclusion in the CHANGELOG

@damacus damacus requested a review from a team March 31, 2022 14:54
@tas50 tas50 merged commit c36381e into main Apr 1, 2022
@tas50 tas50 deleted the deprecation/positional-arguments branch April 1, 2022 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasif-adnan kasif-adnan kasif-adnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damacus @kasif-adnan @tas50