Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting the public IP SkU #187

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

simonjefford
Copy link
Contributor

@simonjefford simonjefford commented Jan 20, 2021

Description

I currently have a need to stand up test kitchen instances in a network with a Nat Gateway in order to get known outbound IP addresses for whitelisting purposes - we don't have ExpressRoute or Private Link set up on this network. In order to do this, public IP resources must have a SKU of "Standard" rather than "Basic". This PR allows this SKU to be set in kitchen.yml.

Issues Resolved

N/A

Check List

  • New functionality includes tests
  • All tests pass
  • PR title is a worthy inclusion in the CHANGELOG

@tas50
Copy link
Member

tas50 commented Feb 11, 2021

@simonjefford This looks good. Can you add something to the readme. We're looking to move that content to the website in the near future and I want to make sure we don't miss this.

Signed-off-by: Simon Jefford <simon.jefford@fourth.com>
@simonjefford
Copy link
Contributor Author

@tas50 that's done - thanks for taking a look

@tas50 tas50 merged commit 48e581b into test-kitchen:master Feb 11, 2021
@tas50
Copy link
Member

tas50 commented Feb 11, 2021

Thanks @simonjefford. I'll get this shipped now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants