Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Kitchen::Driver::Credentials class #128

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Refactor Kitchen::Driver::Credentials class #128

merged 3 commits into from
Mar 8, 2020

Conversation

jasonwbarnett
Copy link
Contributor

@jasonwbarnett jasonwbarnett commented Mar 3, 2020 •
edited
Loading

Description

Refactor of Kitchen::Driver::AzureCredentials (was Kitchen::Driver::Credentials) class to make things overall simpler and easier to add features later.

Changes

  • Renamed Kitchen::Driver::Credentials to Kitchen::Driver::AzureCredentials
  • Removed unused ::singleton method from Kitchen::Driver::AzureCredentials
  • Refactored entire Kitchen::Driver::AzureCredentials

Issues Resolved

N/A

Check List

  • New functionality includes tests
  • All tests pass
  • PR title is a worthy inclusion in the CHANGELOG

@jasonwbarnett jasonwbarnett changed the title Refactor Credentials class Refactor Kitchen::Driver::Credentials class Mar 3, 2020
@jasonwbarnett jasonwbarnett force-pushed the refactor-credentials-class branch from b0451e8 to effbc92 Compare March 4, 2020 15:59
@jasonwbarnett
Refactor Credentials class
efd7f13 
Signed-off-by: Jason Barnett <jason.w.barnett@gmail.com>
@jasonwbarnett jasonwbarnett force-pushed the refactor-credentials-class branch from effbc92 to aa81b9d Compare March 4, 2020 16:00
@jasonwbarnett jasonwbarnett force-pushed the refactor-credentials-class branch from aa81b9d to fbd2f24 Compare March 4, 2020 16:02
@stuartpreston
Copy link
Contributor

Thanks very much for this! Great improvement!

@stuartpreston stuartpreston merged commit b3ee524 into test-kitchen:master Mar 8, 2020
@jasonwbarnett jasonwbarnett mentioned this pull request Mar 23, 2020
Merged
3 tasks
@jasonwbarnett jasonwbarnett deleted the refactor-credentials-class branch March 23, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonwbarnett @stuartpreston