Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exports: pdf exports link overlay #940

Merged
merged 9 commits into from
Feb 28, 2023
Merged

exports: pdf exports link overlay #940

merged 9 commits into from
Feb 28, 2023

Conversation

berniexie
Copy link
Contributor

@berniexie berniexie commented Feb 28, 2023 •
edited
Loading

I had to convert the pdf export units to "pt" to support X and Y.

Here's an example:
links.pdf

@berniexie berniexie requested review from alixander and a team February 28, 2023 22:07
@berniexie berniexie marked this pull request as ready for review February 28, 2023 22:07
gavin-ts
gavin-ts reviewed Feb 28, 2023
View reviewed changes
alixander
alixander approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 🚀

cat.pdf

@berniexie berniexie linked an issue Feb 28, 2023 that may be closed by this pull request
overlay links on PDFs #891
Closed
@berniexie berniexie merged commit 2ddea93 into terrastruct:master Feb 28, 2023
@berniexie berniexie deleted the pdf-link-overlay branch February 28, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-ts gavin-ts gavin-ts left review comments

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overlay links on PDFs
3 participants
@berniexie @alixander @gavin-ts