-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dagre: stop container edges at container label #880
Merged
gavin-ts
merged 10 commits into
terrastruct:master
from
gavin-ts:adjust-dagre-edge-for-container-label
Feb 23, 2023
Merged
dagre: stop container edges at container label #880
gavin-ts
merged 10 commits into
terrastruct:master
from
gavin-ts:adjust-dagre-edge-for-container-label
Feb 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a65fddf
to
3584bf0
Compare
alixander
requested changes
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add @bo-ku-ra 's example as an e2e test? #823 (comment) |
alixander
approved these changes
Feb 23, 2023
|
oh interesting. so arrowhead label and shape can overlap. that's a different issue then, and layout engine agnostic. i'll change that issue to reflect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when an edge goes to a container, it often conflicts with the container's label so we want to stop the edge at its label instead.
Details
e2ereport changes
new e2e test before/after
closes #823