Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e tests with padding=0, fix bounding box with icons #879

Merged
merged 8 commits into from
Feb 23, 2023

Conversation

alixander
Copy link
Collaborator

Fixes #878

Before

Screen Shot 2023-02-23 at 11 10 23 AM

After

Screen Shot 2023-02-23 at 11 15 07 AM

While I'm at it, closes #682. Tired of discovering a bug in bounding boxes when I go to update docs, it'll now be clear when bounding boxes break.

Every test changed, don't want to include 10 screenshots here, so here's a glance.
Screen Shot 2023-02-23 at 11 18 00 AM

@alixander alixander merged commit b46cc7d into terrastruct:master Feb 23, 2023
@alixander alixander changed the title Rune e2e tests with padding=0, fix bounding box with icons Run e2e tests with padding=0, fix bounding box with icons Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bounding box needs to consider icons in outside placement switch e2e tests to 0 padding
1 participant