Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container dimensions, check layout feature support #845

Merged
merged 4 commits into from
Feb 20, 2023
Merged

container dimensions, check layout feature support #845

merged 4 commits into from
Feb 20, 2023

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Feb 19, 2023 •
edited
Loading

  1. Removes restriction of adding dimensions on containers
  2. Adds a check of compatibility between feature and layout. There's issue reports and confusion when we let features be used when it's not supported by the layout engine. E.g. near key being set to another object doesn't work. They think it's a bug on our side.

closes #844

@alixander alixander requested a review from nhooyr February 19, 2023 06:29
@alixander alixander mentioned this pull request Feb 19, 2023
Closed
@alixander
Copy link
Collaborator Author

alixander commented Feb 19, 2023 •
edited
Loading

(@nhooyr tagged for review of second point of PR -- CLI & plugin changes)

@alixander alixander force-pushed the container-dimensions branch from fc33bff to 5ff1909 Compare February 19, 2023 07:35
nhooyr
nhooyr suggested changes Feb 20, 2023
View reviewed changes
@alixander
Copy link
Collaborator Author

oh i can add #723 to this

@alixander alixander requested a review from nhooyr February 20, 2023 05:15
@alixander alixander merged commit 285bdbe into terrastruct:master Feb 20, 2023
nhooyr
nhooyr reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhooyr nhooyr nhooyr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

width and height should be usable on containers
2 participants
@alixander @nhooyr