serde: fix deserialize

[ejulio-ts]

when rendering the following diagram with TALA, it errored when adding no collision.near: game loop.collision detected

direction: down
first input -> start game -> game loop

game loop: {
  direction: down
  input -> increase bird top velocity

  move bird -> move pipes -> render

  render -> no collision -> wait 16 milliseconds -> move bird
  render -> collision detected -> game over
  no collision.near: game loop.collision detected
}

The reason was that when deserializing the graph, game loop.Children had the full path game loop.collision detection instead of just collision detection. Then, TALA failed to find the near object and resulted in a panic.

[nhooyr]

Could you move the test alex added to the monorepo here into e2etests?

[ejulio-ts]

The e2etest? If so, I can add it, but I don't see a good reason for it. It's not testing anything new and we're not looking for its aesthetics. For example, here it wouldn't catch this bug because it was specific to TALA.

[nhooyr]

The e2etest? If so, I can add it, but I don't see a good reason for it. It's not testing anything new and we're not looking for its aesthetics. For example, here it wouldn't catch this bug because it was specific to TALA.

Well it's not specific to TALA but that's the only part where we currently use the serialization code and the tests don't have an option to use external dagre yet so yea it's fine for now then.

[nhooyr]

✅

[ejulio-ts]

Maybe, it makes sense to keep it in TALA so we detect any changes there ASAP