Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: fix connection label mask position #828

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Feb 15, 2023

Summary

Parts of connections could become hidden because the connection mask didn't always line up with the diagram viewbox since it was always positioned at -pad, -pad.

Details

  • have the label mask match the diagram's viewbox which covers outside labels, icons, 3d etc

example of connections being cut off due to a mismatched mask position

Screen Shot 2023-02-15 at 11 55 15 AM

with fixed mask position

Screen Shot 2023-02-15 at 12 00 27 PM

before

Screen Shot 2023-02-15 at 11 37 35 AM

after

Screen Shot 2023-02-15 at 11 37 56 AM

@gavin-ts gavin-ts marked this pull request as ready for review February 15, 2023 20:01
@gavin-ts gavin-ts requested a review from a team February 15, 2023 20:01
@gavin-ts gavin-ts enabled auto-merge February 15, 2023 20:02
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting

@gavin-ts gavin-ts merged commit a7f5fa0 into terrastruct:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants