Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2 bugs: compiler: underscores in edges; oracle: edge ref #824

Merged
merged 7 commits into from
Feb 15, 2023

Conversation

alixander
Copy link
Collaborator

  1. edge case where creating a new edge with underscores AND common prefix was panicking
  2. moving an object where the most nested reference is an edge

@alixander alixander requested a review from nhooyr February 15, 2023 00:47
@nhooyr
Copy link
Contributor

nhooyr commented Feb 15, 2023

moving an object where the most nested reference is an edge

How is bug 2 related to underscores?

@alixander alixander requested a review from nhooyr February 15, 2023 05:08
@nhooyr
Copy link
Contributor

nhooyr commented Feb 15, 2023

@alixander So do you agree the second bug isn't related to underscores?

@alixander alixander requested a review from nhooyr February 15, 2023 05:28
@alixander
Copy link
Collaborator Author

yeah i guess not. an edge can just be the most nested. surprised this hasn't come up earlier though

@alixander alixander changed the title fix 2 bugs with underscores in compiler and oracle fix 2 bugs: compiler: underscores in edges; oracle: edge ref Feb 15, 2023
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alixander alixander enabled auto-merge February 15, 2023 05:34
@alixander alixander merged commit 7584467 into terrastruct:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants