-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale multi-width unicodes #817
Conversation
awesome! Emoji ZWJ Sequence / U+200D ZERO WIDTH JOINER (ZWJ) especially |
i think the test would require a mixed text of double-byte charactors, single-byte charactors, and emojis, too. |
{style.stroke-width: 15; style.double-border: true} <- there are renderings inside.
|
@bo-ku-ra updated with your tests. the method is not 100% accurate, it gives it a little too wide, but I think by an acceptable amount. What do you think |
@nhooyr tagged you to just take a glance in case anything raises a flag to you, no need to dig into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@alixander |
fyi |
closes #813
closes #513
closes #749
probably missing like 5 other issues @bo-ku-ra 's opened ;)