Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: fix rowless class height #756

Merged
merged 3 commits into from
Feb 4, 2023
Merged

render: fix rowless class height #756

merged 3 commits into from
Feb 4, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Feb 4, 2023

Summary

fixes height of class shape with no rows

Details

new test

Screen Shot 2023-02-03 at 6 31 31 PM

e2e report changes

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html

@gavin-ts gavin-ts marked this pull request as ready for review February 4, 2023 02:33
@gavin-ts gavin-ts requested a review from a team February 4, 2023 02:33
@gavin-ts gavin-ts enabled auto-merge February 4, 2023 02:33
alixander
alixander reviewed Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the top one taller than the middle one?

Screen Shot 2023-02-03 at 9 16 42 PM

alixander
alixander approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh it's class vs table. ok.

@gavin-ts gavin-ts merged commit 2564b55 into terrastruct:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the height of the class-title is not the same.
2 participants
@gavin-ts @alixander