Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequence diagram: group overlap with self edge #728

Merged

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jan 27, 2023

Summary

Fix insufficient space after loop messages when the next message is in a different group.

Details

new test before/after

Note: messages after groups 8,9,10 and 11 are also shifted down for consistent spacing, while messages in group 5 don't require extra spacing.

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (9)

@gavin-ts gavin-ts marked this pull request as ready for review January 27, 2023 02:15
@gavin-ts gavin-ts requested a review from a team January 27, 2023 02:15
@gavin-ts gavin-ts requested a review from alixander January 27, 2023 02:41
@gavin-ts gavin-ts enabled auto-merge January 27, 2023 02:43
@gavin-ts gavin-ts requested a review from alixander January 27, 2023 18:10
@gavin-ts gavin-ts merged commit 9cdce24 into terrastruct:master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sequence Diagram] Self-Reference causes overlap between containers
2 participants