-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d2compiler: Add support for layers, scenarios and steps #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test files still need cleanup.
So people know it's special at least until I fix d2compiler.
alixander
requested changes
Jan 28, 2023
nhooyr
added a commit
to nhooyr/d2
that referenced
this pull request
Jan 28, 2023
4704764
to
30b5b64
Compare
alixander
reviewed
Jan 28, 2023
e2etests/testdata/regression/sequence_diagram_name_crash/dagre/sketch.exp.svg
Outdated
Show resolved
Hide resolved
nhooyr
added a commit
to nhooyr/d2
that referenced
this pull request
Jan 28, 2023
alixander
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending the fix discussed in slack
370def8
to
09dc9fd
Compare
b1f1a1b
to
f3786ba
Compare
8f8b066
to
5268829
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.