-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render: shape specific inner boxes #702
Merged
gavin-ts
merged 37 commits into
terrastruct:master
from
gavin-ts:shape-specific-inner-boxes
Feb 3, 2023
Merged
render: shape specific inner boxes #702
gavin-ts
merged 37 commits into
terrastruct:master
from
gavin-ts:shape-specific-inner-boxes
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19f77b1
to
713fb35
Compare
56fba0c
to
ce0d816
Compare
alixander
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog plz.
alixander
requested changes
Jan 29, 2023
ejulio-ts
approved these changes
Jan 31, 2023
alixander
requested changes
Feb 3, 2023
alixander
approved these changes
Feb 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Defines inner bounding boxes for each shape that labels can be placed in.
Decreases the default shape padding while ensuring labels can still fit in the smaller shapes.
Details
new shapes with inner bounding boxes drawn (default padding 40)
padding 0
without person shape aspect ratio limit of 1.5
padding 100
shapes before/after
package shape top height vs total height before
package shape top height vs total height after
dagre layouts are similar with smaller shapes
extra x padding for tooltip and link icons
e2e report changes (image cut off, see all here)