render: fixing markdown li measurement #665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where sometimes the line height wouldn't be used when combining inline elements into a block. Also adds 1px of height for h1 and h2's border bottom.
Details
li
element had an inline text entry for itself (20.125) then a nestedol
(24), but it should have used the full line height (24) when combining the text with theol
li before
li after
example debugging output
Note: not ideal but still helpful (it goes depth first from
body
and moves one to the right per depth)you can inspect the resulting (width, height) and margin top/ bottom values per element (and compare with values in the browser render)
h1 before/after