Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: fix code measurement with leading newlines #664

Merged
merged 4 commits into from
Jan 14, 2023
Merged

render: fix code measurement with leading newlines #664

merged 4 commits into from
Jan 14, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jan 14, 2023 •
edited
Loading

Summary

Measurements for code shapes wouldn't count leading or trailing newlines.

Details

before/after

Screen Shot 2023-01-13 at 8 05 44 PM

@gavin-ts gavin-ts marked this pull request as ready for review January 14, 2023 04:09
@gavin-ts gavin-ts requested a review from a team January 14, 2023 04:09
alixander
alixander approved these changes Jan 14, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@gavin-ts gavin-ts merged commit c5b814b into terrastruct:master Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code snippet with leading newlines mismeasured
2 participants
@gavin-ts @alixander