Fix non-markdown text shapes #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font-size, bold, italic, and underline were all not supported. it wasn't really important because markdown should cover it all. But, it's still valid constructions in D2 and should work. plus, with font-size not working markdown right now, this is quite necessary for diagram titles
None of the existing tests have any material change. The mask IDs just regenerated due to diagram properties changing (all the text was being incorrectly exported as bold).
The purpose of this is to support my previous PR on diagram titles. Users should be able to set any font size they want. E.g.
closes #527