Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: fix connection stroke clipping #493

Merged
merged 4 commits into from
Dec 21, 2022

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes rendered connections that were clipped by the mask at the top and left edges of the graph.

Details

  • fixes render: bounding box needs to consider edge stroke width #488
  • the connection mask correctly had the same dimensions as the viewbox but we positioned it at 0,0 instead of at -pad,-pad to match the placement of the viewbox
  • removed unused code that previously accounted for connection stroke width when we masked each connection individually
  • test changes are just from the updated mask position

tala self loop in top left corner

before

Screen Shot 2022-12-21 at 1 08 40 PM

after

Screen Shot 2022-12-21 at 1 08 34 PM

@gavin-ts gavin-ts requested a review from a team December 21, 2022 21:18
@gavin-ts gavin-ts marked this pull request as ready for review December 21, 2022 21:18
@gavin-ts gavin-ts enabled auto-merge December 21, 2022 21:20
Copy link
Contributor

@ejulio-ts ejulio-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a moment I thought it was an issue computing the edge bounding box and not with rendering 😅

@gavin-ts gavin-ts merged commit 10c212f into terrastruct:master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render: bounding box needs to consider edge stroke width
2 participants