Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: improve image label placement #474

Merged
merged 8 commits into from
Dec 20, 2022

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Dec 20, 2022

Summary

Updates logic for image label placement to avoid overlaps with container labels.

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_overlapping_image_container_labels_dagre_sketch exp svg

Details

e2e report changes for dagre

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (8)

@gavin-ts gavin-ts marked this pull request as ready for review December 20, 2022 04:18
@gavin-ts gavin-ts requested a review from a team December 20, 2022 04:18
@alixander
Copy link
Collaborator

TODO TALA

Nah, TALA's label placement is good enough

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is for shape: image specifically, does not apply to other shapes with an icon attribute

why not?

@gavin-ts
Copy link
Contributor Author

Note: this is for shape: image specifically, does not apply to other shapes with an icon attribute

why not?

the situation with icons is a bit different more similar to a container+image, updated to move these to inside top center instead which should avoid any overlaps with a container label

Screen Shot 2022-12-19 at 8 48 54 PM

@gavin-ts gavin-ts requested a review from alixander December 20, 2022 04:54
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog plz

@alixander
Copy link
Collaborator

i think this closes #403 too, can u add to PR description

@alixander
Copy link
Collaborator

And this! #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants