-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render: improve image label placement #474
Conversation
Nah, TALA's label placement is good enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is for shape: image specifically, does not apply to other shapes with an icon attribute
why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog plz
i think this closes #403 too, can u add to PR description |
And this! #126 |
Summary
Updates logic for image label placement to avoid overlaps with container labels.
Details
shape: image
specifically, other shapes with anicon
attribute will have labels placed inside top center similarly to a container with an image insidee2e report changes for dagre