Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: elk trace to shape border #459

Merged
merged 4 commits into from
Dec 19, 2022
Merged

render: elk trace to shape border #459

merged 4 commits into from
Dec 19, 2022

Conversation

gavin-ts
Copy link
Contributor

Summary

Fixes connections with elk layout not going all the way to each shape's border.

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (5)

Details

  • trace connections to shape border after elk layout

e2e test changes

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (4)

@gavin-ts gavin-ts requested a review from a team December 18, 2022 04:47
@gavin-ts gavin-ts marked this pull request as ready for review December 18, 2022 04:47
@alixander alixander merged commit 8c2a9d6 into terrastruct:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

@ejulio-ts ejulio-ts ejulio-ts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavin-ts @alixander @ejulio-ts