render: fix sql table overflow

[gavin-ts]

Summary

fixes text overflowing in sql tables when a column with a short name and a long type is present in a table with a column having a long name and short type.

Details

• fixes render: sql table text overflows here #457
• adds sql_table_overflow e2e test for the text overflow
• fixes width calculation for sql_table shapes in d2graph SetDimensions
• exports SQLColumn Name and Type dimensions for rendering

e2e report changes

[ejulio-ts]

looking at sql_table_overflow, it looks like tables are growing in size while rendering.
If that's true, could you try it with some larger diagrams so that we see if this size difference could cause issues?
Maybe, it's worth updating the table dimensions to match it properly too

[gavin-ts]

looking at sql_table_overflow, it looks like tables are growing in size while rendering. If that's true, could you try it with some larger diagrams so that we see if this size difference could cause issues? Maybe, it's worth updating the table dimensions to match it properly too

What do you mean growing in size while rendering? Just that it overflowed? That seems to miss the point, the issue was that we were not measuring the table sizes correctly. we needed to measure the longest width name and the longest width type to get the width of the whole table since we align the types at the end of the longest name and this fixes that. The bug is that if you have a short name (10) and a long type (100), its width on its own is only 110+padding but if you have another where it has a long name (100) and a short type (10), it also has a width of 110+padding but combined in the same table these have a width of 200+padding since we need to align the types at the end of the names

[alixander]

@gavin-ts simply put, layout engine will see the wrong dimensions right? that's bad.

needing the ruler during the drawing phase is also violating expectations. everything's already been exported. the renderer is like a photo printer, no more reshoots.

[gavin-ts]

@gavin-ts simply put, layout engine will see the wrong dimensions right? that's bad.

needing the ruler during the drawing phase is also violating expectations. everything's already been exported. the renderer is like a photo printer, no more reshoots.

the layout engine should have the correct dimensions with this change

I can export the longest name width or offset of the type fields if we don't want to pass in the ruler

[alixander]

🚀