Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: add connection label fill #452

Merged
merged 5 commits into from
Dec 17, 2022
Merged

render: add connection label fill #452

merged 5 commits into from
Dec 17, 2022

Conversation

gavin-ts
Copy link
Contributor

Summary

Connection label background color can now be set with the style.fill attribute.

Screen Shot 2022-12-16 at 3 54 28 PM

Details

  • fixes label backgrounds #451
  • adds fill attribute to connections
  • updates 2 e2e tests to include a connection label with style.fill

font_sizes and stylish tests with style.fill on connection label

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (2)

@gavin-ts gavin-ts marked this pull request as ready for review December 17, 2022 00:00
@gavin-ts gavin-ts requested a review from a team December 17, 2022 00:00
@gavin-ts gavin-ts enabled auto-merge December 17, 2022 00:01
alixander
alixander approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@gavin-ts gavin-ts merged commit d25bb79 into terrastruct:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

label backgrounds
2 participants
@gavin-ts @alixander