Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh: Improve dry run message and add short flag -d #266

Merged
merged 3 commits into from
Nov 29, 2022
Merged

install.sh: Improve dry run message and add short flag -d #266

merged 3 commits into from
Nov 29, 2022

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Nov 29, 2022

No description provided.

@nhooyr nhooyr requested review from alixander and a team November 29, 2022 22:19
alixander
alixander approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u add a screenshot? and i think this worth going into release notes, even if technically release-agnostic

@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 29, 2022

Screenshot 2022-11-29 at 2 32 04 PM

@nhooyr nhooyr requested a review from alixander November 29, 2022 22:34
@nhooyr nhooyr merged commit 39ab231 into terrastruct:master Nov 29, 2022
@nhooyr nhooyr deleted the dry-run-cb0e branch November 29, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhooyr @alixander