update golang.org/x/net to resolve govulncheck #2381
Merged
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6393f57 to
4c3b831
Compare
|
Signed, thanks for the help! |
alixander
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve govulncheck CVE's
within d2 top folder run
govulncheck ./...
Vulnerability #4: GO-2024-3333
Non-linear parsing of case-insensitive content in golang.org/x/net/html
More info: https://pkg.go.dev/vuln/GO-2024-3333
Module: golang.org/x/net
Found in: golang.org/x/net@v0.29.0
Fixed in: golang.org/x/net@v0.33.0
Example traces found:
#1: lib/textmeasure/markdown.go:112:43: textmeasure.MeasureMarkdown calls goquery.NewDocumentFromReader, which calls html.Parse
shows this repo using vulnerable dependencies.
go get golang.org/x/net
go mod tidy
--- I'm not sure what golang version you are building with.
But building with 1.23.4 showed extra CVE's
I had to update to 1.23.6 to resolve them.
--- FYI github can automatically open PR's like this for you.
by enabling dependabot within the security tab
code security
Thanks for a great repo!