Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render: Latex support #229

Merged
merged 18 commits into from
Nov 28, 2022
Merged

render: Latex support #229

merged 18 commits into from
Nov 28, 2022

Conversation

alixander
Copy link
Collaborator

@alixander alixander commented Nov 27, 2022

the language tag latex and tex will now render LaTeX (or rather, the MathJax flavor of it)

Screen Shot 2022-11-27 at 7 54 14 PM

Docs: terrastruct/d2-docs#15

closes #135

@alixander alixander changed the title wip: Latex support render: Latex support Nov 28, 2022
Copy link
Contributor

@ejulio-ts ejulio-ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edges are handled

a: |latex
x = \\frac{1}{2}
|

b: |latex
e = mc^2
|

a -> b: |latex
e = mc^2
|

If we're not going to handle them, we should show an error
If we're going to handle it in another PR, totally fine

I'm used to having latex inside markdown with $$ tags mathjax, but it doesn't seem we support it right now. I get that t it is probably out of scope for this PR, so just letting you know inc are you want to open an issue

@ejulio-ts
Copy link
Contributor

Don't you need to add some NOTICE for mathjax?

@alixander
Copy link
Collaborator Author

Don't you need to add some NOTICE for mathjax?

even better -- the attribution is on the file itself (top)

@alixander alixander requested a review from ejulio-ts November 28, 2022 19:46
@alixander alixander merged commit 3d6c196 into terrastruct:master Nov 28, 2022
@alixander alixander deleted the latex branch November 28, 2022 21:32
Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: Support latex
4 participants