-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic sequence diagrams behind a layout flag #219
Merged
ejulio-ts
merged 7 commits into
terrastruct:master
from
ejulio-ts:basic-sequence-diagrams
Nov 28, 2022
Merged
Adds basic sequence diagrams behind a layout flag #219
ejulio-ts
merged 7 commits into
terrastruct:master
from
ejulio-ts:basic-sequence-diagrams
Nov 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alixander
requested changes
Nov 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's introduce sequence-diagram-specific terminology, starting with s/object/actor
alixander
requested changes
Nov 28, 2022
alixander
reviewed
Nov 28, 2022
alixander
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
d2sequence
layout for sequence diagrams with basic functionality.The layout is behind a flag for now as it will need changes in
D2
for full support. So, to merge these changes in small PRs, lets have it behind a flag that also allows us to test it locally without much friction.Assumptions:
stroke-dash
that is constantNo changelog as this is not ready yet. Will add the line once we got it properly integrated.
here is an example diagram
Updates #99