Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render arrowhead labels #182

Merged
merged 5 commits into from
Nov 24, 2022

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 24, 2022

Summary

Render connection arrowhead labels in svg

Details

before

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_arrowhead_labels_dagre_sketch exp svg

after

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_arrowhead_labels_dagre_sketch exp svg (1)

report (with names updated to include test case/ prefix)

_Users_gavinnishizawa_github_repos_d2_out_e2e_report html (2)

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sick, thx for taking this

if you're not planning to do that TODO in this PR (and I don't think it's necessary to), can u make an issue for the TODO and link?

what's with the empty out/.gitignore?

@alixander
Copy link
Collaborator

i just noticed u didn't even mark this as ready for review yet lol, my b

@gavin-ts
Copy link
Contributor Author

what's with the empty out/.gitignore?

added it so the out directory already exists when you clone

@gavin-ts gavin-ts requested a review from alixander November 24, 2022 04:43
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append changelog!

@gavin-ts gavin-ts merged commit d12d117 into terrastruct:master Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

render: Arrowhead labels
2 participants