Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign nested layout #1602

Merged
merged 35 commits into from
Sep 23, 2023
Merged

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Sep 22, 2023

Summary

Redesign nesting of different layout types (grid, sequence diagram, nears).

Details

  • redesign supports more flexible nesting, and central nested graph/diagram type management
  • will support nested edges in grids and simple edges across diagram types
  • now supports sequence diagrams within grid (TODO including edges see below)
  • support grids in sequence diagram actors (TODO compiler err against nesting in groups/notes)
  • can be adjusted to enable constant nears in any container instead of only at the root level
  • TODO remove compile validation against nested edges in grids
  • TODO test with nested edges in grid/sequence (nested edges follow up PR nested edges within grid cells #1629)
  • adds nested_diagram_types test
  • fixes order of shapes/edges in some tests with constant nears / sequences
  • TODO consider supporting dagre in elk or elk in dagre

nested diagram types

Screenshot 2023-09-21 at 9 13 57 PM

@gavin-ts gavin-ts force-pushed the redesign-nested-layout branch from cee6a92 to f68e8d1 Compare September 22, 2023 04:19
@gavin-ts gavin-ts requested a review from alixander September 22, 2023 04:31
@gavin-ts gavin-ts marked this pull request as ready for review September 22, 2023 04:32
@gavin-ts gavin-ts mentioned this pull request Sep 22, 2023
@gavin-ts gavin-ts force-pushed the redesign-nested-layout branch from f68e8d1 to 31252e6 Compare September 23, 2023 03:13
@gavin-ts gavin-ts enabled auto-merge September 23, 2023 03:16
@gavin-ts gavin-ts merged commit 37246cf into terrastruct:master Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants