Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: playwright not installed #594

Closed
avelino opened this issue Jan 2, 2023 · 2 comments · Fixed by #595 or #713
Closed

docker: playwright not installed #594

avelino opened this issue Jan 2, 2023 · 2 comments · Fixed by #595 or #713

Comments

@avelino
Copy link
Contributor

avelino commented Jan 2, 2023

In the official docker image, playwright is not installed by default and fails to install automatically when in use

$ /usr/local/bin/d2 --sketch -l elk docs/tech/orgchart/orgchart.d2 orgchart.png
2023-01-02 17:50:02.672 [INFO]	(default.stdlib)	<./../../github.com/playwright-community/playwright-go/run.go:107>	(*PlaywrightDriver).DownloadDriver	Downloading driver to /root/.cache/ms-playwright-go/1.20.0-beta-1647057403000
err: failed to install Playwright: could not install driver: could not install driver: could not download driver: Get "https://playwright.azureedge.net/builds/driver/next/playwright-1.20.0-beta-1647057403000-linux.zip": x509: certificate signed by unknown authority
ERROR: Job failed: command terminated with exit code 1

installation (ref):

go run github.com/playwright-community/playwright-go/cmd/playwright install --with-deps
@cyborg-ts cyborg-ts added this to D2 Jan 2, 2023
avelino added a commit to avelino/d2 that referenced this issue Jan 2, 2023
@avelino
docker: add ca-certificates package
ea61235 
fixed: terrastruct#594

```
err: failed to install Playwright: could not install driver: could not install driver: could not download driver: Get "https://playwright.azureedge.net/builds/driver/next/playwright-1.20.0-beta-1647057403000-linux.zip": x509: certificate signed by unknown authority
```
@avelino avelino mentioned this issue Jan 2, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Jan 24, 2023
@nhooyr nhooyr reopened this Jan 24, 2023
@nhooyr nhooyr mentioned this issue Jan 24, 2023
Merged
nhooyr added a commit to nhooyr/d2 that referenced this issue Jan 24, 2023
@nhooyr
Dockerfile: Add playwright support for rendering PNGs
fe16543 
Closes terrastruct#594
@avelino
Copy link
Contributor Author

avelino commented Feb 1, 2023

@nhooyr is there any prediction when we will release this update?

@alixander alixander mentioned this issue Feb 10, 2023
Merged
@alixander
Copy link
Collaborator

@avelino in a few days after #784 is merged! (which fixes our release process)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
3 participants
@avelino @alixander @nhooyr