Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: Use different README template for windows #388

Closed
nhooyr opened this issue Dec 6, 2022 · 1 comment · Fixed by #407
Closed

release: Use different README template for windows #388

nhooyr opened this issue Dec 6, 2022 · 1 comment · Fixed by #407

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Dec 6, 2022

No description provided.

@cyborg-ts cyborg-ts added this to D2 Dec 6, 2022
@nhooyr
Copy link
Contributor Author

nhooyr commented Dec 6, 2022

The binaries should also have the .exe extension in the release archive so that you can add the bin directory to your $PATH and things will just work.

Right now, we add .exe when make install is ran.

@iquiw iquiw mentioned this issue Dec 7, 2022
Closed
nhooyr added a commit to nhooyr/d2 that referenced this issue Dec 8, 2022
@nhooyr
release: On windows use .exe and alter README
6e4df1c 
Closes terrastruct#388
nhooyr added a commit to nhooyr/d2 that referenced this issue Dec 8, 2022
@nhooyr
release: On windows use .exe and alter README
ce0e2b3 
Closes terrastruct#388
@nhooyr nhooyr mentioned this issue Dec 8, 2022
Merged
@nhooyr nhooyr moved this to Done in D2 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release: On windows use .exe and alter README nhooyr/d2
1 participant
@nhooyr