chore: upgrade Kong library to v1.4.0 #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
8aeab7a to
9b529ab
Compare
|
Signed-off-by: i4k <t.nateldemoura@gmail.com>
9b529ab to
257e17a
Compare
Preview of ubuntu-focal/go1.21 tests in 257e17a🔍 View Details on Terramate Cloud .
cmd/terramate/cli
|
Preview of macos-ventura/go1.21 tests in 257e17a🔍 View Details on Terramate Cloud .
cmd/terramate/cli
|
sixstone-qq
approved these changes
Nov 21, 2024
snakster
reviewed
Nov 21, 2024
| @@ -119,6 +119,12 @@ func selectPlanFile(terraformPlan, tofuPlan string) (planfile, provisioner strin | |||
| func (c *cli) runOnStacks() { | |||
| c.gitSafeguardDefaultBranchIsReachable() | |||
|
|
|||
| if len(c.parsedArgs.Run.Command) > 0 { | |||
There was a problem hiding this comment.
Can you briefly explain why this becomes necessarily now?
There was a problem hiding this comment.
they changed the behavior of specifically arg:"" passthrough:"":
alecthomas/kong#436
Maybe I'm missing something but I cannot make it work in in the way it was before...
The passthrough:"" prevents kong from interpretating the flags, so it's needed otherwise commands with same flags as Terramate gets interpreted. The arg:"" is also needed to ... make it an argument, unless there's other option to keep old behavior :(
i4ki
added a commit
that referenced
this pull request
Nov 29, 2024
The `arg:"" passthrough:""` option leads to malparsing of flags. Signed-off-by: i4k <t.nateldemoura@gmail.com>
i4ki
added a commit
that referenced
this pull request
Nov 29, 2024
The `arg:"" passthrough:""` option leads to malparsing of flags. Signed-off-by: i4k <t.nateldemoura@gmail.com>
i4ki
added a commit
that referenced
this pull request
Nov 29, 2024
## What this PR does / why we need it: Revert #1965 due to a Kong bug in the parsing of `arg:""` in conjunction with `passthrough:""`. Example: Works: ``` $ terramate list --unknown-flag Error: parsing cli args [list --unknown-flag] > unknown flag --unknown-flag ``` Fails: ``` $ ./bin/terramate run --test echo ok terramate: Entering stack in / Error: one or more commands failed > executable file not found in $PATH: running `--test echo ok` in stack /: --test ``` ## Which issue(s) this PR fixes: none ## Special notes for your reviewer: ## Does this PR introduce a user-facing change? ``` yes, fixes a command line flag parsing bug. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade Kong in preparation for upcoming cli help changes.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Does this PR introduce a user-facing change?