feat: add aws_security_group_rule_deprecated rule #790
+151
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendrucker
reviewed
Dec 15, 2024
| @@ -0,0 +1,31 @@ | |||
| # aws_security_group_rule_deprecated | |||
|
|
|||
| // TODO: Write the rule's description here | |||
| func (r *AwsSecurityGroupRuleDeprecatedRule) Check(runner tflint.Runner) error { | ||
| resources, err := runner.GetResourceContent(r.resourceType, &hclext.BodySchema{ | ||
| Attributes: []hclext.AttributeSchema{ | ||
| {Name: r.attributeName}, |
There was a problem hiding this comment.
Is there even a need to parse attributes here? Seems not, just the existence of the resource should trigger.
Co-authored-by: Ben Drucker <bvdrucker@gmail.com>
|
Everything addressed, docs reworked. |
|
Not sure how to decide about "enabled by default" and "severity". |
wata727
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a rule which generates a warning if a
aws_security_group_ruleis used. According to the docs theaws_vpc_security_group_egress_ruleoraws_vpc_security_group_ingress_ruleshould be used.https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/security_group_rule